(Bug) Journal Vouchers let you make transactions against title accounts #884
Comments
|
@sfount, do you propose that the title accounts are disabled, or not shown? |
|
I'll take a look at this by disabling title accounts. |
This commit disables the title accounts on all voucher pages. The title accounts are still shown, but are disabled by checking the TITLE bhConstant value. It also does not allow a user to use the same account twice in a simple voucher, as this would lead to an invalid transaction. Closes IMA-WorldHealth#884. Closes IMA-WorldHealth#896.
|
Disabled sounds good to me 👍 That still provides the title 'groups' context but does not allow the user to select accounts that cannot make up a transaction. |
This commit disables the title accounts on all voucher pages. The title accounts are still shown, but are disabled by checking the TITLE bhConstant value. It also does not allow a user to use the same account twice in a simple voucher, as this would lead to an invalid transaction. Closes IMA-WorldHealth#884. Closes IMA-WorldHealth#896.
|
Cool. I've implemented it in #898. |
|
@jnilles @IMA-WorldHealth/bhima-core Do you think that the posting journal server methods should reject a transaction that tries to use a title account or should this just be implemented by limiting the client? I have no problem with limiting the client for now but I know there will always be a way until it is restricted on the server. |
|
@sfount, limiting on the server is a good idea. Ideally, |
This commit disables the title accounts on all voucher pages. The title accounts are still shown, but are disabled by checking the TITLE bhConstant value. It also does not allow a user to use the same account twice in a simple voucher, as this would lead to an invalid transaction. Closes IMA-WorldHealth#884. Closes IMA-WorldHealth#896.
This commit disables the title accounts on all voucher pages. The title accounts are still shown, but are disabled by checking the TITLE bhConstant value. It also does not allow a user to use the same account twice in a simple voucher, as this would lead to an invalid transaction. Closes #884. Closes #896.
Title accounts are currently shown with all other accounts types in the typeahead on journal vouchers. They can also be selected and vouchers can be made from and to title accounts without issue.
Current Behaviour
Title accounts can be selected and are valid accounts for voucher transactions.
Expected Behaviour
Title accounts show not be able to be selected in journal vouchers
A voucher hitting a title account should be rejected and not posted to the journal
The text was updated successfully, but these errors were encountered: