-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Journal vouchers let you submit values less than the stored accuracy #885
Labels
Comments
I'll tackle this one once the bug in #878 is fixed. |
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Nov 14, 2016
This commit implements a precision check as part of the input checks in the complex voucher grid. The grid will now block if someone enters an amount that cannot be stored properly in the database. Closes IMA-WorldHealth#885.
4 tasks
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Nov 14, 2016
This commit implements a precision check as part of the input checks in the complex voucher grid. The grid will now block if someone enters an amount that cannot be stored properly in the database. It also hides the column drop down menus on the ui-grid. Closes IMA-WorldHealth#885.
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Nov 15, 2016
This commit implements a precision check as part of the input checks in the complex voucher grid. The grid will now block if someone enters an amount that cannot be stored properly in the database. It also hides the column drop down menus on the ui-grid. Closes IMA-WorldHealth#885.
sfount
pushed a commit
that referenced
this issue
Nov 18, 2016
This commit implements a precision check as part of the input checks in the complex voucher grid. The grid will now block if someone enters an amount that cannot be stored properly in the database. It also hides the column drop down menus on the ui-grid. Closes #885.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Journal Voucher module currently lets you enter and submit values that are less than the accuracy of the system's database. As the database does not support numbers this low they will be rounded to 0 and cause invalid transactions.
These values should be rejected, both on the client and the server.
The text was updated successfully, but these errors were encountered: