Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Simple Vouchers allows a transaction between identical accounts #896

Closed
jniles opened this issue Nov 14, 2016 · 0 comments
Closed

(bug) Simple Vouchers allows a transaction between identical accounts #896

jniles opened this issue Nov 14, 2016 · 0 comments
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Nov 14, 2016

The simple vouchers page allows a user to create a transaction using the same accounts as both the "to" and "from" field. While it's technically not wrong, I can see it leading to a lot of useless transactions where the user made an incorrect choice and didn't realize it.

Steps to Reproduce

  1. Navigate to vouchers/simple
  2. Input any valid values for the description, type, date, and value fields.
  3. Choose the same two accounts for the "To" and "From" ui-selects.
  4. Submit

Expected Result
An error message stating that the same accounts were duplicated.

Actual Result
A successful Journal Voucher payment.
@jniles jniles added the Bug label Nov 14, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Nov 14, 2016
fix(vouchers): disable title accounts
3e9ee0d 
This commit disables the title accounts on all voucher pages.  The title
accounts are still shown, but are disabled by checking the TITLE
bhConstant value.

It also does not allow a user to use the same account twice in a simple
voucher, as this would lead to an invalid transaction.

Closes IMA-WorldHealth#884.  Closes IMA-WorldHealth#896.
@jniles jniles mentioned this issue Nov 14, 2016
Merged
4 tasks
@jniles jniles self-assigned this Nov 14, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Nov 15, 2016
fix(vouchers): disable title accounts
9441796 
This commit disables the title accounts on all voucher pages.  The title
accounts are still shown, but are disabled by checking the TITLE
bhConstant value.

It also does not allow a user to use the same account twice in a simple
voucher, as this would lead to an invalid transaction.

Closes IMA-WorldHealth#884.  Closes IMA-WorldHealth#896.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 18, 2016
fix(vouchers): disable title accounts
a304304 
This commit disables the title accounts on all voucher pages.  The title
accounts are still shown, but are disabled by checking the TITLE
bhConstant value.

It also does not allow a user to use the same account twice in a simple
voucher, as this would lead to an invalid transaction.

Closes IMA-WorldHealth#884.  Closes IMA-WorldHealth#896.
sfount pushed a commit that referenced this issue Nov 19, 2016
@sfount
fix(vouchers): disable title accounts
7aca6f6 
This commit disables the title accounts on all voucher pages.  The title
accounts are still shown, but are disabled by checking the TITLE
bhConstant value.

It also does not allow a user to use the same account twice in a simple
voucher, as this would lead to an invalid transaction.

Closes #884.  Closes #896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles