Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Negative values can be set for price list items #955

Closed
sfount opened this issue Nov 27, 2016 · 1 comment · Fixed by #973 or #981
Closed

(Bug) Negative values can be set for price list items #955

sfount opened this issue Nov 27, 2016 · 1 comment · Fixed by #973 or #981
Assignees
Labels

Comments

@sfount
Copy link
Contributor

sfount commented Nov 27, 2016

Currently price lists can be set as values or as percentages.

If set as a percentage this will be applied to the sale price of an inventory item, a negative percentage will reduce the price and a positive percentage will increase it.

If set as a value a negative value, this will be allowed by the client - this will be directly set at invoice. Although an invoice cannot be submitted with any value 0 or less this is still set.

Problem
You can set a price list item as a value, less than 0

Expected Behavior
Either the client or server will block a price list item being set as a value and less than 0

@sfount sfount added the Bug label Nov 27, 2016
@jniles
Copy link
Contributor

jniles commented Nov 27, 2016

@sfount @mbayopanda, who is working on this?

@jniles jniles self-assigned this Nov 28, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Nov 29, 2016
This commit fixes the inventory module to restrict users from putting in
negative prices.

Closes IMA-WorldHealth#955.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 29, 2016
This commit fixes the inventory module to restrict users from putting in
negative prices.

Closes IMA-WorldHealth#955.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants