New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AllocationsController #143

Closed

ylyangtw opened this issue Jun 8, 2023 · 1 comment · Fixed by #150

Assignees

Milestone

Contributor

ylyangtw commented Jun 8, 2023

"x-auth-userinfo" and "x-auth-usergroup" are global in most of controllers but AllocationsController use them in each function locally. Need to be refactored to be consistent with other controllers.
JsonUtils.isLoggedInUserAdmin(userGroup) need to be replaced with the updated authorizer (118 refactoring methods in ldapclient and authorizer )
Other controllers may have this issue. Please check them as well.

ylyangtw self-assigned this

Contributor Author

ylyangtw commented Jun 22, 2023

UsageController requires refactoring as well

ylyangtw linked a pull request

that will close this issue

143 refactor AllocationsController and UsageController #150

Merged

ylyangtw mentioned this issue

143 refactor AllocationsController and UsageController #150

Merged

ylyangtw closed this as completed

navarroc added this to the 1.20.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment