New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send rudeconfig changes upstream #56
Comments
Hi there, Any ideas/comments on this please? |
Hi Ankur, The rudeconfig source code in MUSIC is customized for the MUSIC config file syntax. So, these changes cannot be sent upstream. |
I thought so. Do you think it's worth me speaking to rudeconfig upstream to see what they think? MUSIC seems like the only thing that uses rudeconfig at the moment. At the moment, I'm using the bundled copy for the NeuroFedora MUSIC package. Should be reviewed and in Fedora soon. |
Well, if rudeconfig could be generalized in a way to support such extensions that would be nice, of course, but I'm not sure that that makes sense. Do as you find suitable. |
There seem to be changes to the local copy of rudeconfig used in MUSIC which are not present in upstream (https://github.com/mflood/rudeconfig). These should be sent upstream---most downstream distributions do not permit private copies of libraries (bundling).
If these are improvements, I can diff the two sources (upstream and the local copy) and open PRs upstream?
The text was updated successfully, but these errors were encountered: