Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include more complex tests #7

Open
jakobj opened this issue Feb 27, 2016 · 2 comments
Open

include more complex tests #7

jakobj opened this issue Feb 27, 2016 · 2 comments

Comments

@jakobj
Copy link
Contributor

jakobj commented Feb 27, 2016

as far as i can see, our test dictionary is quite simple. it might be a good idea to include more complex examples (e.g., lists of dicts, sets, tuples)

@mschmidt87
Copy link
Collaborator

My opinion on this is that instead of trying to take of all kinds of weird kinds of datasets, we should rather stick to the simple test/examples and wait for users to approach with use cases.
The examples you mentioned might still be sensible and will partly be solved and then also tested in the PR fixing #11 .

@jakobj
Copy link
Contributor Author

jakobj commented Dec 2, 2016

agreed. no need to make up and handcraft use cases. we can consider using hypothesis

@jakobj jakobj added this to the 2.0 milestone May 11, 2017
@mschmidt87 mschmidt87 removed this from the 2.0 milestone Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants