Source position and type cast and brackets

[pvojtechovsky]

This problem was found by #1927

In the code like

someFnc(((File) (null)));

The source position of null literal contains only sources "null", but may be there should be type case (File) and may be also brackets. So source position would contain this: ((File) (null)).

But then I would prefer to have more details in source position. So may be we should introduce ExpressionSourcePosition, which would be similar to DeclarationSourcePosition. It means it would have these parts

• start/end -> "((File) (null))"
• typeCastStart/End -> "(File)"
• expressionStart/End -> "(null)"

@tdurieux Do you think it would make sense to introduce new ExpressionSourcePosition or we can use DeclarationSourcePosition instead here too? Or may be we do not need that at all and source position of expressions is just simple SourcePosition for some reason?

And what about brackets? Are they part of expression or not?

[tdurieux]

Do you think it would make sense to introduce new ExpressionSourcePosition

That is a good question.
What is the difference with the normal SourcePosition?

And what about brackets? Are they part of expression or not?

I would say yes, otherwise there are part of nothing, no?

[pvojtechovsky]

What is the difference with the normal SourcePosition?

normal SourcePosition has only

• start/end of element

while ExpressionSourcePosition will have

• start / end of whole expression including type cast
• typeCastStart/End the type cast part
• expressionStart/End the pure expression part

And what about brackets? Are they part of expression or not?

I would say yes, otherwise there are part of nothing, no?

I agree that braces should be part of expression too (they are actually not it's part.)

[pvojtechovsky]

May be I will have time this evening to have a look at this issue. But I am still not sure about concept of the solution.

I will probably create new class CompoundSourcePositionImpl extends SourcePositionImpl and will change DeclarationSourcePositionImpl extends CompoundSourcePositionImpl.

Where new class CompoundSourcePositionImpl will contain declarationSourceStart and declarationSourceEnd.
So
CompoundSourcePositionImpl will have these fields:

• sourceStart/End - start end of whole expression including type cast and brackets
• declarationSourceStart/End - start end of expression itself excluding type cast or brackets

WDYT?

[tdurieux]

It seems good for me. Thanks