Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoon maven version #5307

Closed
MartinWitt opened this issue Jun 22, 2023 · 1 comment · Fixed by #5311
Closed

Spoon maven version #5307

MartinWitt opened this issue Jun 22, 2023 · 1 comment · Fixed by #5311

Comments

@MartinWitt
Copy link
Collaborator

We have some issue regarding the maven version. Some users want a minimal maven version, #4248 while from a security perspective, we should use an update to date one. The MavenLauncher uses internally mvn dependency:build-classpath. This command should invoke at least the maven dependency resolution, which will make network calls. This has a large attack surface. The old solution with version ranges has the problem of build reproduction. Version ranges make a maven build non-reproducible, see #5300 for the PR I merged.
Any opinions or solutions to this?

@MartinWitt
Copy link
Collaborator Author

@I-Al-Istannen showed me the Maven-invoker is using the system installed maven. So, we could safely downgrade to an outdated maven version and add a comment explaining this old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant