New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseTypes_RelatedParty_allow CharacterString additionally to PT_FreeText #69
Comments
I'm not sure that this is actually an issue? According to the XML schema that includes <element minOccurs="0" name="organisationName" nillable="true" type="gmd:PT_FreeText_PropertyType">
<xs:complexType name="PT_FreeText_PropertyType">
<xs:complexContent>
<xs:extension base="gco:CharacterString_PropertyType">
<xs:sequence minOccurs="0">
<xs:element ref="gmd:PT_FreeText"/>
</xs:sequence>
</xs:extension>
</xs:complexContent>
</xs:complexType> So Meaning that both the following are valid: <base2:organisationName>
<gco:CharacterString>NameOfOrganisation</gco:CharacterString>
</base2:organisationName> <base2:organisationName>
<gco:CharacterString>NameOfOrganisation</gco:CharacterString>
<gmd:PT_FreeText>
<gmd:textGroup>
<gmd:LocalisedCharacterString locale="https://id.loc.gov/vocabulary/iso639-2/dan">Organisationsnavn</gmd:LocalisedCharacterString>
</gmd:textGroup>
</gmd:PT_FreeText>
</base2:organisationName> One can wonder
However, perhaps the pragmatic solution here would not to change anything, and provide only the |
Dear @heidivanparys, thank you for your input. I agree with your conclusion, I had thought about the same. In addition, I don't see any error with the multiplicities:
|
I agree with you, there's no need to change XSD Schema for RelatedParty. Currently, both CharacterString and PT_FreeText are allowed. However UML model points to more specific CharacterString implementation which is PT_FreeText. I don't see any error with the multiplicities as @fabiovin. |
I have to agree with @pawelsoczewski on the UML issue. Formally, while you can replace a type with a derived type, the opposite (replacing a derived type with it's parent) is incorrect. |
Subgroup meeting on 13.09.2022: |
Related "Implementation examples" category discussion: INSPIRE-MIF/helpdesk#135 |
Change proposal description
According to the implementing rules, RelatedParty.individualName, RelatedParty.organisationName and RelatedParty.positionName have PT_FreeText as type.
This is also true for other types defined in the INSPIRE models whereas others use CharacterString when text is required.
As the use of PT_FreeText does not always make sense but does for some use cases/countries, I would propose to allow both, PT_FreeText and CharacterString for all properties that currently use one of them. So far, I only met data providers who wanted to use CharacterString instead of PT_FreeText (not the other way around) but as I assume that PT_FreeText is in use and needed for some other countries/cases, I assume that allowing both would be the easiest solution)
The validator already accepts both (at least in cases where PT_FreeText is demanded in the IR, but CharacterString is used)
Issue faced
PT_FreeText is more complex but not neccessary/fully used in most of the cases.
Current behaviour
Some text properties use PT_FreeText, some use CharacterString. The validator does not check for it.
Proposed solution
PT_FreeText and CharacterString are both allowed for all properties that currently use either, or.
Additional information
Proposal reason
The current schema version does not support the use case that some providers only need simple text fields (CharacterString) whereas others need more complex ones (PT_FreeText).
Addressed schema
All schemas using PT_FreeText and/or CharacterString
Impact on INSPIRE TG / IR
The IR would need to be updated to allow the use of both wherever they occur.
Change proposer
Johanna Ott, wetransform GmbH (on behalf of various customers that want to use CharacterString instead of PT_FreeText in most of the cases).
References
More detailed documentation
This is a follow up ticket of this thread in the INSPIRE Thematic cluster.
It is created because of a proposal in this issue discussing the handling of the two types in the validator.
Both can be read/used as sources for more input/discussions that already took place.
The text was updated successfully, but these errors were encountered: