Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF - Layer and styles should be changed #17

Closed
JohannaOtt opened this issue Nov 9, 2021 · 6 comments · Fixed by #165
Closed

AF - Layer and styles should be changed #17

JohannaOtt opened this issue Nov 9, 2021 · 6 comments · Fixed by #165
Labels
endorsed The change proposal is endorsed by the MIG.
Milestone

Comments

@JohannaOtt
Copy link

JohannaOtt commented Nov 9, 2021

Change proposal description

The validator expects the layer "AF.Site", the TG defines "AF.Sites"
The validator expects the styles "AF.AgriculturalHolding.Default" and "AF.Site.Default", the TG defines "AF.AgriculturalHolding" and "AF.Site"

Addressed TG

Data Specification on Agricultural and Aquaculture Facilities – Technical Guidelines

Location

chapter 11

Issue faced

Should be aligned with values expected by validator

Proposed solution

Change AF.Sites to AF.Site, change AF.AgriculturalHolding to AF.AgriculturalHolding.Default, change AF.Site to AF.Site.Default.

@JohannaOtt JohannaOtt changed the title AF - Layer AF.Sites should be changed to AF.Site AF - Layer and styles should be changed Nov 9, 2021
@heidivanparys
Copy link
Collaborator

https://github.com/inspire-eu-validation/ets-repository/blob/28b66265aab8fc8228672283887475818aade1ab/service/vs-wms-soapui-project.xml#L2304-L2309

From the Data Specifications Template:

image

From the AF data specification:

image

image

image

image

image

image

@JohannaOtt

Change AF.Sites to AF.Site, change AF.AgriculturalHolding to AF.AgriculturalHolding.Default, change AF.Site to AF.Site.Default.

I think that more changes have to be done, as illustrated in the screenshots above.

@JohannaOtt
Copy link
Author

I think that more changes have to be done, as illustrated in the screenshots above.

Looks good!

@heidivanparys
Copy link
Collaborator

Meeting 15-12-2021: The changes are fine, but we have to double-check the legislation.

@heidivanparys heidivanparys added the for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. label Dec 15, 2021
@heidivanparys
Copy link
Collaborator

heidivanparys commented Dec 15, 2021

I noticed two more places in the DS that are affected:

image

image

@heidivanparys
Copy link
Collaborator

The relevant part of the legislation, from https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:02010R1089-20141231#tocId16:

Article 14

Portrayal

  1. For the portrayal of spatial data sets using a view network service as specified in Commission Regulation No 976/2009 ( 5 ), the following shall be available:

    (a) the layers specified in Annex II for the theme or themes the data set is related to;
    (b) for each layer at least a default portrayal style, with as a minimum an associated title and a unique identifier.

Regarding Site: the legislation says "AF.Site" as layer name, see https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:02010R1089-20141231#tocId947, whereas the TG currently says "AF.Sites".

The legislation does not say anything about the names of the styles, as far as I can see.

@sMorrone
Copy link
Collaborator

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Apr 4, 2022
@fabiovinci fabiovinci added this to the 2024.1 milestone Dec 1, 2023
@fabiovinci fabiovinci linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants