Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SU - AreaStatisticalUnit geometry type definition is not correct #38

Open
ulbrichtd opened this issue Mar 10, 2022 · 8 comments · Fixed by #120
Open

SU - AreaStatisticalUnit geometry type definition is not correct #38

ulbrichtd opened this issue Mar 10, 2022 · 8 comments · Fixed by #120
Labels
for JRC The change proposal is to be handled by the JRC. impact on IR The change proposal has an impact on the IR. impact on UML The change proposal has an impact on the UML diagram. impact on validator The change proposal has an impact on the INSPIRE validator.

Comments

@ulbrichtd
Copy link

Change proposal description

According to Commission Regulation (EU) No 1253/2013 the geometry type of AreaStatisticalUnit must be GM_MultiSurface (constraint on AreaStatisticalUnit in section 1.3.1.2.).

The document Data Specification on Statistical Units - Technical Guidelines is currently missing this information. The UML class diagram for "Vector package" (figure 7 in section 5.3.1.2.3) suggests that GM_Object is allowed to describe the geometry.

Addressed TG

Data Specification on Statistical Units - Technical Guidelines

Location

Data Specification on Statistical Units - Technical Guidelines

  • UML class diagram for "Vector package" (figure 7 in section 5.3.1.2.3)
  • a constraint on AreaStatisticalUnit is missing

Issue faced

The INSPIRE validator enforces at the moment geometries as GM_MultiSurface and does not allow GM_Surface. According to the Commission Regulation (EU) No 1253/2013 this is correct. According to the Data Specification on Statistical Units - Technical Guidelines GM_Surface should be allowed to describe the geometry.

Proposed solution

Update UML diagram mentioned above and/or add a constraint on AreaStatisticalUnit.

Pull request

Not available as the TG is not yet available in the repository.

Additional information

Impact on INSPIRE validator

Linked issue

INSPIRE-MIF/helpdesk-validator#714

@fabiovinci fabiovinci added impact on UML The change proposal has an impact on the UML diagram. impact on validator The change proposal has an impact on the INSPIRE validator. labels Mar 10, 2022
@fabiovinci
Copy link
Collaborator

The constraint in the IR says:

image

The use of "should" is strange in a constraint since, as clearly stated in the MD TG (see screenshot below), this form of the verb shall be used for recommendations.

image

Let's discuss whether the "Constraints of the spatial object type AreaStatisticalUnit" should be treated as a "constraint" (and in this case, AreaStatisticalUnit must have a GM_MultiSurface reference geometry) or as a "recommendation".

In both cases, the TG must be amended.

@fabiovinci fabiovinci added the for Sub-group The change proposal is to be assessed by the Sub-group label Mar 17, 2022
@hogredan
Copy link

Dear @fabiovinci ,

the use of "should" is indeed strange as for other constraints in the IR usually "shall" or "must" are used.
I didn't check other translations but in the German translation, the constraint of AreaStatisticalUnit was translated as "shall".
Therefore, I assume that this is an error in the IR and suggest to treat the "Constraints of the spatial object type AreaStatisticalUnit" as a "constraint".

@fabiovinci
Copy link
Collaborator

Dear @hogredan,

I agree with you, it seems an error in the IR.

Looking at other translations, there are different results, e.g. in Italian, it has been translated as "should" and in Spanish, it seems that it has been translated as "shall".

image

@MarcoMinghini
Copy link
Contributor

Checking the latest version of the IR, this is indeed the only occurrence of the word "should" in a Constraints section, which suggests that this in an error (unfortunately not spotted and thus not leading to a correction in the upcoming amended version).

@sMorrone sMorrone added for JRC The change proposal is to be handled by the JRC. and removed for JRC The change proposal is to be handled by the JRC. labels Mar 24, 2022
@sMorrone
Copy link
Collaborator

Subgroup meeting on 24.03.2022:
support by the JRC is requested regarding the interpretation of the IR contraint.

@sMorrone sMorrone added for JRC The change proposal is to be handled by the JRC. and removed for Sub-group The change proposal is to be assessed by the Sub-group labels Mar 24, 2022
@MarcoMinghini
Copy link
Contributor

The JRC believes that the use of should in the IR constraint is a mistake, since constraints are meant to provide an obligation rather than a suggestion. However, there is no specific definition of 'constraint' in the IR ensuring that all constraints are indeed obligations (in contrast, constraints in the IR make use of several different terms such as have to, must, is required, can only be, applies only, can, have).

Therefore, we should still make it possible to use GM_Surface as a geometry, and relax the corresponding test in the INSPIRE Reference Validator (which at the moment enforces the use of GM_MultiSurface). At the same time, we should keep track of this issue to possibly update the legal text in the next revision.

@fabiovinci
Copy link
Collaborator

According to those conclusions, the related ATS has been modified and the test will be relaxed in the Validator.
Updates on the implementation status will be communicated through the related issue in the helpdesk-validator.

@fabiovinci fabiovinci added the impact on IR The change proposal has an impact on the IR. label Jun 22, 2022
@fabiovinci fabiovinci added this to the 2023.2 milestone May 19, 2023
@fabiovinci fabiovinci linked a pull request Jul 21, 2023 that will close this issue
@fabiovinci
Copy link
Collaborator

The missing constraint was added to the TG and to the UML.
The issue will remain open to keep track of this issue to possibly update the legal text in the next revision of IR.

@fabiovinci fabiovinci removed this from the 2023.2 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for JRC The change proposal is to be handled by the JRC. impact on IR The change proposal has an impact on the IR. impact on UML The change proposal has an impact on the UML diagram. impact on validator The change proposal has an impact on the INSPIRE validator.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants