Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You cant transfer your zoom from the standard to hierarchy view. #301

Open
FredrikKarlssonSpeech opened this issue Aug 12, 2021 · 1 comment

Comments

@FredrikKarlssonSpeech
Copy link

If you mark a portion of the signal and zoom into that portion, you see only the transcription that belongs to that portion of the signal. This selection is then not transferred to the hierarchy view, which I was expecting at least. This makes working in the hierarchy view more cumbersome than it needs to I think.

@samgregory
Copy link
Contributor

samgregory commented Mar 12, 2022

Hi @FredrikKarlssonSpeech,
I agree, that the hierarchy view isn't as intuitive as it could be. It turns out that implementing your suggestion was much harder than it first appeared.
Do you have the means to build EMU-webApp from a git source? I'd like someone to test out what I've done and give some feedback before I make a pull request for this change:
https://github.com/samgregory/EMU-webApp/tree/hierarchy-zoom

Basically, the hierarchy view doesn't match up with the labeler view because the time information isn't used. Instead each of the item labels on a level are equally spaced (unless they are collapsed). Therefore I had to make a way to calculate which items were in view and how this related to the total number on that level. I've built in a small adjustment (of 10%) because things didn't line up perfectly.

I've yet to implement the rotated transformation but it will only require a few more lines of code.
Another approach that might work would be to collapse every label node that isn't in labeler view but that might confuse people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants