Validation of DBconfig doesn't seem to take place

[MJochim]

Follow-up to #296.

In commits 786ef8c~2 through 786ef8c (recently) and 74af424 (years ago), additions were made to the DBconfig.json regarding the EMU-webApp config and y-axis limits. However, they were never added to the JSON schema.

I expected the web app to throw a validation error when loading a database with such a config, but it doesn't. Maybe it only validates _annot.json files, but not _DBconfig.json? Is that intentional? Is that a problem?

It may have to do with the fact that this reference is wrong:

EMU-webApp/src/schemaFiles/DBconfigFileSchema.json

Line 183 in 786ef8c

"EMUwebAppConfig": { "$ref": "https://raw.githubusercontent.com/IPS-LMU/EMU-webApp/master/app/schemaFiles/emuwebappConfigSchema.json"}

The URL yields a 404 error, because it contains /app/ instead of /src/.

[MJochim]

@samgregory noted in #296 that the emuwebappConfigScheme allows for additionalProperties in the signalCanvases object:

EMU-webApp/src/schemaFiles/emuwebappConfigSchema.json

Line 317 in 4e6bcf2

"additionalProperties": true

Which is true, although I suppose we had better change that. We hardly ever set additionalProperties: true in any of our schemas and I don’t see a reason why we should have an exception here.

Anyway, one problem exists apart from that: I have found out now that the DBconfig is passed through the validator (tv4), but the EMUwebAppConfig part of it is ignored. Also, changing /app/ to /src/ in the $ref URL, as I mentioned in my previous comment, does not fix the issue. While the validator function tv4.validate() can handle the quoted $ref, it does not download the URL by itself. We have to do that actively, and I have yet to figure out how.