Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelList - sorting and then resizing causes loadItems() to be called while dragging/resizing #94

Open
tma-isbx opened this issue Dec 15, 2016 · 0 comments

Comments

@tma-isbx
Copy link
Contributor

https://github.com/ISBX/isbx-loopback-cms/blob/master/client/app/dashboard/model/list/ModelList.js#L692

The $watch on the 'sortInfo' is constantly fired, and newVal !== oldVal because newVal and oldVal also include the column, which includes the columns width.

Proposed solution: instead of comparing all of newVal and oldVal, we should compare if the sort attributes we depend on have changed (sortInfo.fields and sortInfo.directions).

https://github.com/ISBX/isbx-loopback-cms/blob/master/client/app/dashboard/model/list/ModelList.js#L295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant