Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRIS: IOC for McLennan PM600 Motion Controller #1099

Closed
kjwoodsISIS opened this issue Mar 23, 2016 · 4 comments
Closed

IRIS: IOC for McLennan PM600 Motion Controller #1099

kjwoodsISIS opened this issue Mar 23, 2016 · 4 comments
Assignees

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Mar 23, 2016

As a scientist, I need an IOC for the McLennan PM600 Motion Controller, so that I can control the IRIS rotating centre-stick.

Acceptance Criteria
  1. I can control a McLennan PM600 Motion Controller a console (using caput, caget, etc.).
  2. I can control a McLennan PM600 Motion Controller from a genie_python script.
Notes
  1. There is a PM600 driver available from the EPICS web-site.
  2. McLennan web-site
@FreddieAkeroyd
Copy link
Member

Code pushed in ISISComputingGroup/EPICS-ioc#60

@AdrianPotter
Copy link

Some notes from testing the IOC this week. I've been using the test stage David was working with. The IOC talks to the controller as expected, but the controller isn't getting the motor to move. I couldn't determine why.

The IOC is good, but there are a few changes to make it work as expected with IBEX:

  • The PV names are currently of the form MOT:MTR01. They are missing their controller index (e.g. MTR0101). To avoid overlap with the Galils, the macros need setting up so that the McLennan controllers occupy a different band of controller numbers. The Galils currently use the defined address macros to assign controller numbers. Do we want to do the same with the McLennans?
  • The description for the Galil PV should have (GALIL) appended as in (MCLEN) to distinguish the motor types. I've already created a branch of the ibex_gui which widens the motor record OPI to accommodate the extra length.
  • The Galils only pass the MTR* part of the macro to the db, the McLennan passes MOT:MTR*. The most obvious effect of this is that the PV description for the McLennan motor record contains a MOT: that the Galils don't. This at least should be corrected.

@AdrianPotter AdrianPotter self-assigned this Aug 17, 2016
@AdrianPotter
Copy link

ISISComputingGroup/EPICS-motor#1
ISISComputingGroup/EPICS-ioc#68

Note that the IOC PR are changes I've made since David's code was added to the repo. The ticket involves the entirety of ioc/master/MCLEN, not just the changes I've made.

Also note that, unlike the Galil, this is a level 1 motor and supports very little simulation functionality. Rather than spending more time trying to emulate level 3 simulation capability, I've returned the ticket as is owing to the urgency of getting the McLennan ready for Iris. Enhancing simulation behaviour can be submitted under a separate ticket if required.

@AdrianPotter
Copy link

For review, please come get the McLennan from my desk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants