Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAT: WPI Syringe Pump IOC & OPI #3261

Closed
kjwoodsISIS opened this issue Jun 13, 2018 · 7 comments
Closed

IMAT: WPI Syringe Pump IOC & OPI #3261

kjwoodsISIS opened this issue Jun 13, 2018 · 7 comments

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Jun 13, 2018

As an IMAT scientist, I need a driver so that I can use a WPI SP2XX Syringe Pump in my experiment.

Acceptance Criteria

  1. Solution to be ready for 26th June.
  2. Other acceptance criteria - TBD (depending on chosen solution)

Notes

  1. Scientist requesting this work is Genoveva Burca.
  2. LabVIEW VI for WPI SP2XX Syringe Pump already exists:
    1. Front Panel VI: C:\LabVIEW Modules\Drivers\WPI SP2XX Pumps\WPI SP2XX Pump - System.llb\WPI SP2XX Pump - System - Front Panel.vi
    2. Setup Dialog: C:\LabVIEW Modules\Drivers\WPI SP2XX Pumps\WPI SP2XX Pump - System.llb\WPI SP2XX Pump - System - Setup Dialog.vi
    3. Documentation: C:\LabVIEW Modules\Drivers\WPI SP2XX Pumps\Documentation
  3. The work to be done for this ticket is as follows:
    1. Determine if support for WPI SP2XX Syringe Pump can be implemented via lvDCOM.
      1. If so, do it (create appropriate XML file, front-panel OPI & setup dialog OPI)
      2. If not, proceed to steps ii - iv.
    2. Examine existing VIs to discover which sub-set of commands are supported.
    3. Implement these as an IOC
    4. Create OPIs corresponding to the Front Panel & Setup Dialog.
  4. For reference: WPI SP2xx Syringe Pump.
  5. It would be worth discussing the functionality required with Gareth and/or the scientist .
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2018_06_07 milestone Jun 13, 2018
@kjwoodsISIS
Copy link
Contributor Author

Whoever picks this up: please estimate the number of story points.

@ghost ghost self-assigned this Jun 13, 2018
@ghost ghost added in progress and removed ready labels Jun 14, 2018
@GDH-ISIS
Copy link

WPI SP2XX Syringe Pump hardware now in office. Connected to MOXA - port 8. Device is talking so the cabling is correct. Documentation forwarded.

@GDH-ISIS
Copy link

For anybody developing this device driver and uses LabVIEW as a reference, please ensure they are using the latest version from SourceSafe. It was modified recently.

@ghost
Copy link

ghost commented Jun 21, 2018

Added the following features to the IOC:

  • run: starts the device
  • stop: stops the device
  • dia: sets the diameter
  • dia?: gets the present diameter settings
  • run?: gets the current run status
  • mode: sets the mode of the device
  • mode?: gets the mode of the device
  • dir?: gets the direction of the device
  • dir rev: reverses the direction of the device.
  • error?: queries for the error
  • Also added mismatch for errors raised using "\r\nE".
  • Added PV to check when NA is returned as a prompt when setting run, stop, dir rev or dia.

Note: the tests use parameterized 0.6.1. Please install this package to run the tests correctly.

@John-Holt-Tessella
Copy link
Contributor

Commands left to do (from the manual) looks like:

  • del?
  • ratei
  • ratei?
  • ratew?
  • ratew
  • voli
  • volw
  • voli?
  • rev

@DominicOram
Copy link
Contributor

Also tested #3275 as part of this. Issues I found were mostly just tidying up. In the interest of speed I will merge this and further issues are in #3287. Note that I could not get the device to produce any errors so had to rely on IOCTests for error cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants