Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_bourne: resource leak and other issues #5280

Closed
FreddieAkeroyd opened this issue Feb 29, 2020 · 8 comments
Closed

json_bourne: resource leak and other issues #5280

FreddieAkeroyd opened this issue Feb 29, 2020 · 8 comments

Comments

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Feb 29, 2020

json bourne stopped working #5279 and was consuming a large amount of memory. There were multiple log messages about connection failures, so it looks like connection failures cause at least a memory leak. I forgot to check the handle count, but looking at the new process i believe it is also leaking socket handles as the handle count is increasing. Have attached a process monitor to verify this. Error logs are on the server.

acceptance criteria

  • running perfmon shows no memory or handle leak in presence of connection failures
  • can we write system/unit tests for this?
@FreddieAkeroyd
Copy link
Member Author

image

@FreddieAkeroyd
Copy link
Member Author

red is handle count

@FreddieAkeroyd
Copy link
Member Author

note: json bourne is currently using the caffi rather than ca backend to cachannel - this was because ca didn;t seem to be available in python 3.8 when it was installed

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Feb 29, 2020

note: json bourne is currently using the caffi rather than ca backend to cachannel - this was because ca didn;t seem to be available in python 3.8 when it was installed

https://github.com/ISISComputingGroup/genie_python/pull/221 uses python 3.8 with the full ca CaChannel backend if you want to try it?

@FreddieAkeroyd
Copy link
Member Author

@Tom-Willemsen should i copy the files from the genie python PR pipeline build?

@FreddieAkeroyd
Copy link
Member Author

Handle leak still present after moving to 3.8 with native caChannel, lots of connection errors in logs so maybe something is not getting cleaned up on error

@FreddieAkeroyd FreddieAkeroyd added this to the SPRINT_2020_02_06 milestone Mar 1, 2020
@Tom-Willemsen Tom-Willemsen self-assigned this Mar 2, 2020
@Tom-Willemsen Tom-Willemsen moved this from Ready to In Progress in IBEX Project Board Mar 2, 2020
@Tom-Willemsen Tom-Willemsen moved this from In Progress to Review in IBEX Project Board Mar 2, 2020
@JamesKingWork JamesKingWork changed the title jsob_bourne: resource leak and other issues json_bourne: resource leak and other issues Mar 3, 2020
@Tom-Willemsen
Copy link
Contributor

Now deployed and no longer looks to be leaking handles.

@Tom-Willemsen Tom-Willemsen moved this from Review to Review Complete in IBEX Project Board Mar 3, 2020
@FreddieAkeroyd
Copy link
Member Author

image

memory and handle slook good

IBEX Project Board automation moved this from Review Complete to Done Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants