Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Python 3 client build #5389

Closed
DominicOram opened this issue Apr 9, 2020 · 13 comments
Closed

Create a Python 3 client build #5389

DominicOram opened this issue Apr 9, 2020 · 13 comments
Assignees
@Tom-Willemsen
Labels
5 fixed
Milestone
SPRINT_2020_05_28

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Apr 9, 2020 •
edited
Loading

As a instrument scientist I would like to confirm that my scripts work under python 3. As such I would like a Python 3 release that I can test them against. This ticket is to create and deploy a Python 3 client on all the instruments. The client will consist of:

As this is not the release that will be run in the next cycle it doesn't need to be thoroughly tested.

Acceptance Criteria

  • All instruments have the latest version of the client with Python 3
  • INSTETC updated
@DominicOram DominicOram mentioned this issue Apr 16, 2020
Closed
@John-Holt-Tessella John-Holt-Tessella added this to Proposals in Planning Apr 23, 2020
@DominicOram DominicOram moved this from Proposals to High in Planning Apr 23, 2020
@DominicOram DominicOram mentioned this issue Apr 24, 2020
Closed
1 task
@DominicOram
Copy link
Contributor Author

Whilst doing this we need to make a decision as to whether to update NICOS, see #5351

@DominicOram
Copy link
Contributor Author

Also deploy this

@DominicOram DominicOram added the 5 label Apr 30, 2020
@kjwoodsISIS kjwoodsISIS removed this from High in Planning Apr 30, 2020
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2020_04_30 milestone Apr 30, 2020
@DominicOram
Copy link
Contributor Author

DominicOram commented May 1, 2020 •
edited by Tom-Willemsen
Loading

Depends on

@John-Holt-Tessella
Copy link
Contributor

It may also need a custom deploy script

@John-Holt-Tessella John-Holt-Tessella added this to Proposals in Planning via automation May 28, 2020
@John-Holt-Tessella John-Holt-Tessella moved this from Proposals to From ready in Planning May 28, 2020
@DominicOram DominicOram moved this from From ready to High in Planning May 28, 2020
@kjwoodsISIS kjwoodsISIS removed this from High in Planning May 28, 2020
@Tom-Willemsen
Copy link
Contributor

Text to add to email to instrument scientists after deployment:

As part of the migration to Python 3, we have changed the mechanism by which instrument scripts are imported into the inst module. Existing functions should be unaffected by this change, but new functions may need to be added to C:\Instrument\Settings\config\<inst name>\Python\inst\__init__.py before they are available as part of the inst module. See https://github.com/ISISComputingGroup/ibex_user_manual/wiki/Python-3#changes-with-instrument-scripts-due-to-python-3 for further details about this change.

@DominicOram DominicOram mentioned this issue Jun 4, 2020
Closed
9 tasks
@Tom-Willemsen Tom-Willemsen self-assigned this Jun 8, 2020
@Tom-Willemsen Tom-Willemsen moved this from Ready to In Progress in IBEX Project Board Jun 8, 2020
@Tom-Willemsen
Copy link
Contributor

Given that we need to deploy changes to instetc, blockcache etc I think deploying a full release makes most sense (it also makes sure we deploy a consistent release).

@FreddieAkeroyd
Copy link
Member

Will we be doing a full release testing cycle?

@Tom-Willemsen
Copy link
Contributor

My feeling is that we should do minimal (smoke) tests for basic functionality for this release, and do a full release test cycle before the "full" release for cycle (which will probably be 7.1.0 or 7.0.1).

@FreddieAkeroyd
Copy link
Member

We plan to do a proper release at start of August I believe, but this does mean that if an instrument started testing things in July it would have a less well tested IBEX version. Do we feel there are enough changes that a full rerelease is best? INSTETC is something that could be done another way, is it best for a full release for blockcache?

@kjwoodsISIS
Copy link
Contributor

I am rather nervous about deploying a "full" release without the nature of the release being made explicitly clear to scientists. I really don't want hear complaints from scientists saying "it's buggy", "you didn't test it". Right now, when everything is so uncertain, I can forsee some scientists being very concerned if a "buggy" release of IBEX is put in front of them (even if we do plan to follow up with a fully tested release later).

@Tom-Willemsen
Copy link
Contributor

In a meeting with @FreddieAkeroyd @kjwoodsISIS @John-Holt-Tessella we decided:

  • We will deploy the "full" version of ibex (client, server, genie_python) soon as 7.0.0 to all machines.
  • We will not run all of the manual system tests for 7.0.0, instead we will do a limited set of "smoke tests".
  • We will inform the scientists that we are upgrading all of IBEX, and that this includes Python 3. The purpose of this release is primarily to allow scientists to test python 3, although other changes are also included.
  • We won't start deploying 7.0.0 until the system_tests_iocs are (mostly) green again (currently all emulators are failing).
  • There will be a further release in August, probably 7.0.1 or 7.1.0. For this release we will do the full manual system tests as usual. This will be the release that they run during next cycle.

@FreddieAkeroyd
Copy link
Member

liveview will not work until #5467 is merged, not sure of that is really an issue at the moment though

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Jun 11, 2020 •
edited
Loading

Deploy using instrument_deploy_7.0.0.bat:

  • ALF
    • Started
    • Complete
  • CRISP
    • Started
    • Complete
  • EMMA-A
    • Started
    • Complete
  • EMU
    • Started
    • Complete
  • ENGINX
    • Started
    • Complete
  • ENGINX_SETUP
    • Started
    • Complete
  • GEM
    • Started
    • Complete
  • HRPD
    • Started
    • Complete
  • IMAT
    • Started
    • Complete
  • INES
    • Started
    • Complete
  • IRIS
    • Started
    • Complete
  • IRIS_SETUP
    • Started
    • Complete
  • LARMOR
    • Started
    • Complete
  • LET
    • Started
    • Complete
  • LOQ
    • Started
    • Complete
  • MAPS
    • Started
    • Complete
  • MARI
    • Started
    • Complete
  • MERLIN
    • Started
    • Complete
  • MUONFE
    • Started
    • Complete
  • NIMROD
    • Started
    • Complete
  • OSIRIS
    • Started
    • Complete
  • POLARIS
    • Started
    • Complete
  • RIKENFE
    • Started
    • Complete
  • SANDALS
    • Started
    • Complete
  • SELAB
    • Started
    • Complete
  • SURF (not doing this time - will get deployed to before the next REFL tests anyway)
  • TOSCA
    • Started
    • Complete
  • VESUVIO
    • Started
    • Complete
  • ZOOM
    • Started
    • Complete

@Tom-Willemsen Tom-Willemsen moved this from In Progress to Review in IBEX Project Board Jun 16, 2020
@John-Holt-Tessella John-Holt-Tessella moved this from Review to Review Complete in IBEX Project Board Jun 17, 2020
IBEX Project Board automation moved this from Review Complete to Done Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Willemsen Tom-Willemsen

Labels
5 fixed
Projects
None yet
Milestone
SPRINT_2020_05_28
Development

No branches or pull requests
5 participants
@FreddieAkeroyd @kjwoodsISIS @John-Holt-Tessella @DominicOram @Tom-Willemsen