GUI: autocomplete runs function (!)

[Tom-Willemsen]

In the ibex gui scripting console type:

def x():
    print("hello")

Then x(). (to trigger the autocomplete) - the GUI prints "Hello" in a loop - this is very bad if e.g. the function has some effects that should not run immediately.

Worse, if x() does time.sleep(...) it hangs the GUI for that amount of time.

I think we probably need to fix this one and deploy a hotfix in time for cycle...

[Tom-Willemsen]

See if we can simply disable autocomplete as a hotfix for instruments.

[rerpha]

i tried giving this a go, i dont think its as simple as just setting an ipython autosuggest/turning jedi off, and also seems to be limited to the client scripting perspective (couldnt reproduce in a standalone genie_python.bat). I think setting autocomplete to off can be done by some pydev prefs, but im not sure on how to actually set them in a good way

[rerpha]

pydev pr: ISISComputingGroup/Pydev#4
ibex gui: ISISComputingGroup/ibex_gui#1525

I have updated the p2 repo to the pydev branch in the first PR.

next steps for this ticket:

• create a patch release for the client for this change
• decide who to actually deploy it to (just SANS/REFL, or all insts running v12.0.1?)

[Tom-Willemsen]

In a meeting with myself, @ThomasLohnert @FreddieAkeroyd @KathrynBaker we decided:

• We will create a patch release with the hotfix above to disable autocomplete.
• We will patch this on all TS2 instruments as a priority
• We will prioritise looking for a better fix for TS1 instruments
  • If we find a better fix - great - we will deploy that to TS1 in time for beam
  • If we don't find a better fix, we will deploy the hotfix above to TS1 instruments closer to beam start

[Tom-Willemsen]

Deploys (TS2):

• WISH
• LARMOR
• INTER
• POLREF
• SANS2D
• ZOOM
• IMAT
• LET
• NIMROD

TS1:

• LOQ
• MUSR
• RIKENFE
• ALF

[rerpha]

We are going to close this ticket as we are happy that we've patched to everyone that needs the issue, which has been present since very early days of the GUI. Ticket will be created for the implementation of a solution (probably in PyDev) as well as a task for checking that we are deploying it or the workaround to the next release group in summer.

[FreddieAkeroyd]

Having installed pvdev into a standalone eclipse, the behaviour is definitely there. As noted in #7850:

• in editor view autocomplete doesn't run the function
• in the pydev console it does run the function
  It may be possible to fix by looking through https://github.com/ISISComputingGroup/Pydev/tree/master/plugins/org.python.pydev.ast/src/org/python/pydev/ast/codecompletion and/or posting a bug report to pydev