Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTER: update slit panels on reflectometry OPI #8061

Closed
3 tasks
ThomasLohnert opened this issue Oct 13, 2023 · 1 comment
Closed
3 tasks

INTER: update slit panels on reflectometry OPI #8061

ThomasLohnert opened this issue Oct 13, 2023 · 1 comment
Assignees

Comments

@ThomasLohnert
Copy link
Contributor

As an INTER scientist, I would like the reflectometry OPI to reflect the real state of the physical beamline. After the upgrade, they do not have a Slit4 anymore, so S4VG/HG should be removed. They would however like to control S3 in beam blocker mode, so a control for toggling this should be added (see POLREF screen in /reflectometry/POLREF/vgaps.opi in resources folder).

Acceptance Criteria

  • Reflectometry front panel for INTER does not show S4
  • Reflectometry front Panel for INTER does show S3 beam blocker toggle button
  • Layout is clear and readable

Extra Information

Why it is needed?

Where required files/links are

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@ThomasLohnert
Copy link
Contributor Author

ThomasLohnert commented Oct 24, 2023

PRs:
ISISComputingGroup/ibex_gui#1627
#8074

Scientists have since asked to add the activation parameter for Monitor 3 to the "important parameters" on the front panel so I have added that to this PR as well.

@ThomasLohnert ThomasLohnert added this to the SPRINT_2023_10_05 milestone Oct 25, 2023
@rerpha rerpha closed this as completed Oct 30, 2023
IBEX Project Board automation moved this from Review to Review Complete Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants