Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GALIL: allow COM in GALILADDR macro #8218

Closed
1 task
FreddieAkeroyd opened this issue Feb 6, 2024 · 4 comments
Closed
1 task

GALIL: allow COM in GALILADDR macro #8218

FreddieAkeroyd opened this issue Feb 6, 2024 · 4 comments

Comments

@FreddieAkeroyd
Copy link
Member

As a user i would like to be able to type COM4 38400 as well as 192.168.1.1 into the GALILADDR macro

Acceptance Criteria

  • typing above does not display pattern mismatch error

How to Test

  • need to run make iocstartups after swapping branch and then restart server
@FreddieAkeroyd FreddieAkeroyd changed the title [Instrument or device name, e.g. WISH]: [Brief description of request] GALIL: allow COM in GALILADDR macro Feb 6, 2024
@FreddieAkeroyd FreddieAkeroyd self-assigned this Feb 6, 2024
@FreddieAkeroyd FreddieAkeroyd added this to Ready in IBEX Project Board via automation Feb 6, 2024
@FreddieAkeroyd FreddieAkeroyd added this to the SPRINT_2024_02_01 milestone Feb 6, 2024
@github-actions github-actions bot added the ready label Feb 6, 2024
@FreddieAkeroyd FreddieAkeroyd moved this from Ready to In Progress in IBEX Project Board Feb 6, 2024
@github-actions github-actions bot added in progress and removed ready labels Feb 6, 2024
@FreddieAkeroyd FreddieAkeroyd moved this from In Progress to Review in IBEX Project Board Feb 6, 2024
@rerpha
Copy link
Contributor

rerpha commented Feb 6, 2024

Looks good - could you patch onto galil-old of ioc\master please, I guess we'll need this there as well

@rerpha rerpha closed this as completed Feb 6, 2024
IBEX Project Board automation moved this from Review to Review Complete Feb 6, 2024
@FreddieAkeroyd
Copy link
Member Author

Thanks @rerpha in fact probably more important in galil-old than where it is currently

@rerpha
Copy link
Contributor

rerpha commented Feb 6, 2024

Just a thought, as I think this works fine for the short term, but perhaps long term we should do something similar to the CCD where we have a baud rate macro which has no default, then do a stringiftest to see if it exists then set up serial comms if so? And allow PORT to either be an IP or COMx

just thinking this might be less confusing for users as they might not be able to decipher the regex

@FreddieAkeroyd
Copy link
Member Author

That would be simpler to a user, but ideally a user would not see the regex at all and would just see an example of that to type (an example attribute in the XML). Having PORT as COM or IP would still be a bit of a horrible regex for a user, i see the CCD has separate PORT and IPADDR macros. I see a bit of an issue using BAUD from a working point of view, we have to say it had no default if we are using it as a check, but then we don't want to make it mandatory as that means COM not IP. So i can see how the mechanism would work, but just our current wording may be a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants