Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEARL: remove DISP setting code from #8244

Closed
1 task done
rerpha opened this issue Feb 27, 2024 · 1 comment
Closed
1 task done

PEARL: remove DISP setting code from #8244

rerpha opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels
1 added during sprint no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@rerpha
Copy link
Contributor

rerpha commented Feb 27, 2024

From CR of PEARL: the runstate setting is causing some issues with running experiments, so instead of being locked out unless in SETUP we would like to just defer the responsibility of this to our own scripts (basically to add some confirmation prompt to say "are you sure you want to set this script while running")

Acceptance criteria

  • DISP setting code is removed from PEARLPC

We might as well keep the underlying code in utilities as it may be helpful in the future.

To test this, pull changes, start server and add pearlpc as devsim, then try and set a pressure while your simulated DAE is RUNNING. if this works this change is successful

@rerpha rerpha added this to the SPRINT_2024_02_01 milestone Feb 27, 2024
@rerpha rerpha added this to Ready in IBEX Project Board via automation Feb 27, 2024
@rerpha rerpha self-assigned this Feb 27, 2024
@github-actions github-actions bot added the ready label Feb 27, 2024
@rerpha rerpha added the no_release_notes Tickets that do not need release notes, use sparingly! label Feb 27, 2024
@rerpha
Copy link
Contributor Author

rerpha commented Feb 27, 2024

ISISComputingGroup/EPICS-ioc#831
ISISComputingGroup/EPICS_PearlPressure#13
release notes are a bit weird as im just reverting adding it in the first place #8245

@rerpha rerpha moved this from Ready to Review in IBEX Project Board Feb 27, 2024
@github-actions github-actions bot added review and removed ready labels Feb 27, 2024
IBEX Project Board automation moved this from Review to Review Complete Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 added during sprint no_release_notes Tickets that do not need release notes, use sparingly!
Projects
Status: Done
Development

No branches or pull requests

3 participants