Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature_method_to_disable_builtin_function #129

Closed
wants to merge 2 commits into from
Closed

feature_method_to_disable_builtin_function #129

wants to merge 2 commits into from

Conversation

hexofyore
Copy link
Contributor

@hexofyore hexofyore commented May 18, 2023 •
edited by ISibboI

112- disabling built-in functions

Builtin functions can be disabled in context.

Description

In the context, Builtin functions can be disabled. If builtin functions are called, it returns Error.

List here your changes

  • I added the method to disable builtin functions.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • The changes I've made are Windows, Linux compatible

Closes #112

@hexofyore
Copy link
Contributor Author

@ISibboI

@ISibboI ISibboI self-assigned this May 19, 2023
@hexofyore
Copy link
Contributor Author

What happened with doc? I reverted change on readme and changed lib.rs file.

ISibboI
ISibboI requested changes May 19, 2023
View reviewed changes
Copy link
Owner

@ISibboI ISibboI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the pull request! It is already in a pretty nice state, but there are some comments that we should still address.

src/context/mod.rs Outdated Show resolved Hide resolved
src/context/mod.rs Show resolved Hide resolved
src/context/mod.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/context/mod.rs Show resolved Hide resolved
src/context/mod.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/integration.rs Outdated Show resolved Hide resolved
@ISibboI
Copy link
Owner

ISibboI commented May 19, 2023

What happened with doc? I reverted change on readme and changed lib.rs file.

You need to execute sync-readme

@ISibboI ISibboI added the enhancement New feature or request label May 19, 2023
@hexofyore
Copy link
Contributor Author

Ok. I will change them.

@hexofyore
Copy link
Contributor Author

@ISibboI I changed them.

@hexofyore hexofyore requested a review from ISibboI May 19, 2023 15:52
@ISibboI
Copy link
Owner

ISibboI commented May 21, 2023

Thanks, I can take it from here.

ISibboI pushed a commit that referenced this pull request May 21, 2023
@zeroishero @ISibboI
Resolving issues for PR #129
24c1749
@ISibboI
Copy link
Owner

ISibboI commented May 21, 2023

Well I have integrated the changes now, but it seems that github does not recognise that. Hence I will have to close this, even though it is technically merged. Thank you a lot for the contribution!

@ISibboI ISibboI closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISibboI ISibboI Awaiting requested review from ISibboI

Assignees

@ISibboI ISibboI

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disabling built-in functions
3 participants
@hexofyore @ISibboI @zeroishero