Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload does not work with new 4TU platform #73

Open
manuGil opened this issue Mar 20, 2023 · 5 comments
Open

Upload does not work with new 4TU platform #73

manuGil opened this issue Mar 20, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@manuGil
Copy link
Collaborator

manuGil commented Mar 20, 2023

Uploading dataset fails due to changes in the endpoints of the new platform of the repository.
A new client for fairly should be developed to solve this issue.

@manuGil manuGil added the bug Something isn't working label Mar 20, 2023
@roelj
Copy link
Collaborator

roelj commented Mar 20, 2023

Or perhaps we could figure out how to make it work with the new 4TU platform. :)

@girgink
Copy link
Contributor

girgink commented Mar 20, 2023

Because the new platform is not compatible with the Figshare API it requires a new client. Similar endpoint URLs do not bring compatibility as long as their behaviour are significantly different from the reference implementation. If you provide a proper API documentation if will be useful.

@roelj
Copy link
Collaborator

roelj commented Mar 20, 2023

Well if that's what you conclude, then that is what you conclude. I'd like to see if perhaps after we work out some bugs in the new 4TU platform we can make it compatible for your purpose.

@girgink
Copy link
Contributor

girgink commented Mar 23, 2023

Sure, we will be happy to report the issues we identified. I think some of them might be design decisions, not bugs, e.g. not providing account/categories end point. Do you target 100% compatibility?

@jurra
Copy link
Collaborator

jurra commented Apr 19, 2023

Or perhaps we could figure out how to make it work with the new 4TU platform. :)

Just to clarify both options mentioned by @roelj and @manuGil are the same option. When Manuel refers to developing a new client, it means a new client extension within our fairly package with a client implementation for 4TU. So it wouldn't be a new package exclusively for 4TU, it would be an extension of the package, or a plugin for 4TU if you like ;)

Indeed if 4TU web API is fully compatible with figshare, then we can simply reuse figshare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants