Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing studies: silent fail if target user cannot access certain services #619

Closed
newton1985 opened this issue Apr 21, 2022 · 6 comments
Closed
Assignees
Labels
Feedback Feedback through frontend

Comments

@newton1985
Copy link

Long story short

When I try to share a study with a user, it may appear as though it has been successfully shared to the owner, but the "sharee" cannot see the study in his/her studies tab because he/she does not have access to a specific service inside the study (e.g. S4L).

Expected behaviour

In these circumstances, there are several obvious options: 1) make it impossible for the owner to share a study with a target who does not have access to all services inside that study (with an informative error message, including the specific problematic services), or 2) the study shows up in the studies tab of the target user, but with a lock (and an informative error message if access is attempted).

Actual behaviour

Silent failure: target user cannot see shared study.

Steps to reproduce

Share a study with a user who does not have access to one or more services inside that study.

Note: your environment was attached but will not be displayed

@newton1985 newton1985 added the Feedback Feedback through frontend label Apr 21, 2022
@odeimaiz
Copy link
Member

odeimaiz commented Apr 21, 2022

I would go for the second option:
The study shows up in the study browser, but with a lock or another icon (and an informative message in the tooltip)

@GitHK
Copy link
Contributor

GitHK commented Jun 10, 2022

I'd say this is closed? @newton1985 please reopen it if you think otherwise.

@GitHK GitHK closed this as completed Jun 10, 2022
@elisabettai
Copy link
Collaborator

Reopening since I'm still experiencing it (i.e. shared a study with collaborator who did not have access to latest service version and he did not see the study card at all, instead of seeing it blocked).

@elisabettai
Copy link
Collaborator

@sanderegg, this can be closed now, right? Well, I know that I was the one re-opening it.

@sanderegg
Copy link
Member

@elisabettai I would vote yes.
@newton1985 ?

@newton1985
Copy link
Author

+1 yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback through frontend
Projects
None yet
Development

No branches or pull requests

8 participants