Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release master -> Staging_switzer2 #744

Closed
7 tasks done
pcrespov opened this issue Oct 18, 2022 · 2 comments
Closed
7 tasks done

Pre-release master -> Staging_switzer2 #744

pcrespov opened this issue Oct 18, 2022 · 2 comments
Assignees
Labels
release Preparation for pre-release/release

Comments

@pcrespov
Copy link
Member

pcrespov commented Oct 18, 2022

In preparation for pre-release. Here an initial (incomplete) list of tasks to prepare before pre-releasing:


check important changes 🚨

  • Motivation: @GitHK important fixes for dy-services

devops check (⚠️ devops)

  • No special preparations required
  • disable cron job to restart scheduler in staging deploys after this pre-release (to test #3444)
  • cleanup staging AWS (orphan services etc)

e2e testing check

  • No major issues

Draft Changelog

Added

  • ✨Dy-services: cli command for cleanly closing services after error (#3430)

Changed

  • ✨ Implements #3453: fail boot if invalid product setup (#3455)

Fixed

  • 🐛Dy-services: no longer push outputs when service starts (#3443)
  • 🐛Dy-services: retry on 400 RequestTimeout when uploading (#3448)
  • 🐛Dy-services: dy-sidecar sometimes does not save state and outputs (#3438) 🚨[ TODO:
    • open a study a lot of juqpuyters and generate some data each the nodes
    • Leave it open for a very long time in the tab
    • If any services gets restarted and the data is saved the fix worked as expected ]
  • 🐛 Fixes #3372: removes future warning of alias in BaseSettings (#3454)

Deprecated

Removed

Security / Maintenance

  • 🔨 Maintenance/type checker repo-wide (#3450)
  • 🔒️⬆️ Maintenance/upgrade vulnerable nbconvert (#3451)
  • ⬆️ Maintenance/update dask-services (#3444) 🚨 [ TODO: rm cron job that restart dask-scheduler ]
  • ⬆️ Bump actions/setup-node from 3.5.0 to 3.5.1 (#3452)
  • ⬆️ 📝Maintenance/week 41 updates testing+tooling dependencies and CITATIONS (#3442)

** Legend **

  • ✨ New feature
  • 🐛 Fixes bugs
  • ♻️ Refactors code
  • ⬆️ Upgrades dependencies
  • 🔒️ Fixes security issues
  • 🔨 Adds or updates development scripts or CI.
  • 🚨 important change. REQUIRES app-level testing before releasing to production
  • 📌 can be cherry-picked to production

Summary

  • what: make release-staging name=switzer version=2 git_sha=dbcc9a645f25468ed57d227c42e8daad6ccb62d8 in master
  • who: @Surfict @GitHK
  • when: THURSDAY Oct.20, afternoon
@pcrespov pcrespov self-assigned this Oct 18, 2022
@pcrespov
Copy link
Member Author

@ITISFoundation/dev-team FYI this pre-release is currently target for Thursday

@Surfict
Copy link
Collaborator

Surfict commented Oct 20, 2022

Release has been done.

We experienced a problem with the CI (the one from the original commit, not the one from the release) who failed to tag and push the dask-sidecar image (nothing in the logs - it just didn't do it, didn't show an error). Restarting the CI mades it works. We didn't find the origin of the problem - the commit doesn't update the CI files or the Makefile.

@pcrespov pcrespov added this to the Katherine Switzer milestone Nov 4, 2022
@pcrespov pcrespov added the release Preparation for pre-release/release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparation for pre-release/release
Projects
None yet
Development

No branches or pull requests

3 participants