Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common functionality for aiohttp and httpx clients #2156

Closed
pcrespov opened this issue Feb 18, 2021 · 1 comment
Closed

Common functionality for aiohttp and httpx clients #2156

pcrespov opened this issue Feb 18, 2021 · 1 comment
Assignees
@pcrespov
Labels
a:services-library issues on packages/service-libs

Comments

@pcrespov
Copy link
Member

We use two clients to communicate via web API in our system, namely aiohttp and httpx (in fastapi services)

Should have a common approach for all of them that define policies like retry, timeouts, circuit-breaks or error handling.

A first trial was done in the director-v2 with the client-decorators. This approach is in the good direction but proved to be very confusing since it is not obvious for the user that it modifies the returned values. It needs further development.
@pcrespov pcrespov added the a:services-library issues on packages/service-libs label Feb 18, 2021
@pcrespov pcrespov self-assigned this Feb 18, 2021
@pcrespov pcrespov mentioned this issue Feb 18, 2021
Merged
4 tasks
@sanderegg sanderegg mentioned this issue Apr 28, 2022
Closed
2 tasks
@sanderegg sanderegg mentioned this issue Oct 5, 2022
Closed
@pcrespov
Copy link
Member Author

pcrespov commented Apr 8, 2024

New policy based classes in servicelib.fastapi

@pcrespov pcrespov closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

Labels
a:services-library issues on packages/service-libs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcrespov