-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize catalog services endpoint #2313
Optimize catalog services endpoint #2313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
========================================
- Coverage 71.7% 68.4% -3.4%
========================================
Files 506 506
Lines 19912 19927 +15
Branches 1949 1947 -2
========================================
- Hits 14293 13633 -660
- Misses 5143 5858 +715
+ Partials 476 436 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4bec6bc
to
de52810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitively an improvement! :-)
Please consider the suggested changes . There are important changes and I also think we should start adding more testing to the catalog
services/catalog/src/simcore_service_catalog/api/dependencies/database.py
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/db/repositories/services.py
Outdated
Show resolved
Hide resolved
if service_in_db.owner: | ||
service.owner = await groups_repository.get_user_email_from_gid( | ||
service_in_db.owner | ||
with ProcessPoolExecutor() as pool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we have an executor pool per application instead of per request? Did you test the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. saw nothing, no measureable improvement
de15043
to
aa320a1
Compare
services/catalog/src/simcore_service_catalog/api/routes/services.py
Outdated
Show resolved
Hide resolved
138e4f4
to
778fbdf
Compare
What do these changes do?
gained a few 100ms in the operation, hopefully might help in the 20 users access osparc from the CI case
Related issue/s
How to test
Checklist