Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: remove access to non defined variable #2316

Merged
merged 1 commit into from
May 11, 2021

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 4, 2021

What do these changes do?

  • removes access to non-defined variable when running sidecar through the CLI

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:sidecar issue related with the sidecar worker service label May 4, 2021
@sanderegg sanderegg added this to the Schwarznasenschaf milestone May 4, 2021
@sanderegg sanderegg self-assigned this May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2316 (c7c7b00) into master (6a4c45b) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head c7c7b00 differs from pull request most recent head 45280ba. Consider uploading reports for the commit 45280ba to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2316     +/-   ##
========================================
- Coverage    71.7%   71.7%   -0.1%     
========================================
  Files         506     506             
  Lines       19927   19932      +5     
  Branches     1950    1949      -1     
========================================
+ Hits        14299   14302      +3     
- Misses       5150    5153      +3     
+ Partials      478     477      -1     
Flag Coverage Δ
integrationtests 61.9% <ø> (+<0.1%) ⬆️
unittests 67.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/executor.py 77.3% <ø> (-0.2%) ⬇️
...src/simcore_service_storage/s3wrapper/s3_client.py 67.5% <0.0%> (-1.4%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 72.6% <0.0%> (+<0.1%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 75.7% <0.0%> (+0.9%) ⬆️

@sanderegg sanderegg requested a review from GitHK May 10, 2021 11:14
@sanderegg sanderegg requested a review from pcrespov May 10, 2021 11:55
@sanderegg sanderegg merged commit e0b4343 into ITISFoundation:master May 11, 2021
@sanderegg sanderegg deleted the remove_sidecar_globals branch May 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:sidecar issue related with the sidecar worker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants