Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webserver build process improvements #2354

Open
sanderegg opened this issue May 28, 2021 · 3 comments
Open

webserver build process improvements #2354

sanderegg opened this issue May 28, 2021 · 3 comments
Assignees

Comments

@sanderegg
Copy link
Member

Some proposals for next iterations on the static-webserver:

  • moving client compile as a stage of static-webserve/Dockerfile will accelerate image build (notice that make build-x always start compiling the front-end and cannot parallelize)
  • rename web/sever -> webserver so it follows the same pattern as the rest
  • move web/client outside of web. I suggest even outside services and have a clients folder so in the future we could even have multiple frontends? just a suggestion ...

Originally posted by @pcrespov in #2353 (comment)

@pcrespov
Copy link
Member

pcrespov commented Feb 9, 2022

@odeimaiz how do you feel about these changes (read last point above). This shall give the front-end even more independence . It is a first step to even connect to any backend while developing.

@pcrespov pcrespov self-assigned this Feb 9, 2022
@odeimaiz
Copy link
Member

odeimaiz commented Feb 9, 2022

I don't see any benefits, but if you want to move all the files from /services/web/client/ to /clients/qx/, go for it.

@sanderegg
Copy link
Member Author

#3367 fulfilled first point. build time is reduced by a substantial amount as the client is now built in parallel with the other services instead of sequentially. CI is faster, as are local builds (30% improvement on a local dev machine for production builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants