Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes session cookies for /studies with latest aiohttp #2386

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 17, 2021

What do these changes do?

  • CHANGES: removes constraint on aiohttp (due to bug ⚗️ web-server refactoring backlog #2008) and upgrades all web-server dependencies
    • Cannot upgrade yarl due to change in the quotation (see test for details)
  • FIXES: session cookies in studies_access

Related issue/s

How to test

  • webserver tests
make devenv
source .venv/bin/activate
cd services/web/server
pytest --pdb -vv tests/unit/with_dbs/02/test_access_to_studies.py

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Jun 17, 2021
@pcrespov pcrespov added this to the Marmoset milestone Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #2386 (bc643b6) into master (adc686b) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2386     +/-   ##
========================================
- Coverage    74.8%   74.7%   -0.1%     
========================================
  Files         516     516             
  Lines       20036   20038      +2     
  Branches     1972    1972             
========================================
- Hits        14989   14984      -5     
- Misses       4526    4530      +4     
- Partials      521     524      +3     
Flag Coverage Δ
integrationtests 67.3% <33.3%> (-0.1%) ⬇️
unittests 68.2% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/src/simcore_service_webserver/studies_access.py 88.9% <100.0%> (+0.2%) ⬆️
...ages/service-library/src/servicelib/aiopg_utils.py 87.5% <0.0%> (-3.2%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 72.0% <0.0%> (-0.9%) ⬇️
.../director/src/simcore_service_director/producer.py 61.0% <0.0%> (-0.5%) ⬇️

@pcrespov pcrespov marked this pull request as draft June 17, 2021 06:53
@pcrespov pcrespov changed the title 🐛 Fixes session cookies for /studies with latest aiohttp WIP: 🐛 Fixes session cookies for /studies with latest aiohttp Jun 17, 2021
@pcrespov pcrespov changed the title WIP: 🐛 Fixes session cookies for /studies with latest aiohttp 🐛 Fixes session cookies for /studies with latest aiohttp Jun 17, 2021
@pcrespov pcrespov requested a review from GitHK June 17, 2021 09:20
@pcrespov pcrespov marked this pull request as ready for review June 17, 2021 09:27
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jun 17, 2021
@pcrespov pcrespov merged commit 314560e into ITISFoundation:master Jun 17, 2021
@pcrespov pcrespov deleted the is2008/fix-session-aiohttp-constraint branch June 17, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants