Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance/Director-v2 to use settings library #2427

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

Migrates the director-v2 to use the settings-library

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #2427 (c600ff4) into master (895b0f9) will decrease coverage by 0.0%.
The diff coverage is 93.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2427     +/-   ##
========================================
- Coverage    75.5%   75.4%   -0.1%     
========================================
  Files         560     558      -2     
  Lines       20868   20769     -99     
  Branches     2018    2008     -10     
========================================
- Hits        15757   15674     -83     
+ Misses       4577    4563     -14     
+ Partials      534     532      -2     
Flag Coverage Δ
integrationtests 66.2% <89.8%> (-0.1%) ⬇️
unittests 69.2% <90.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/api/routes/computations.py 91.2% <ø> (ø)
...-v2/src/simcore_service_director_v2/core/errors.py 57.5% <ø> (-0.8%) ⬇️
...re_service_director_v2/modules/dynamic_services.py 90.6% <ø> (ø)
...imcore_service_director_v2/modules/remote_debug.py 28.5% <0.0%> (ø)
...c/simcore_service_director_v2/modules/scheduler.py 96.7% <ø> (ø)
...gs-library/src/settings_library/docker_registry.py 94.1% <66.6%> (-5.9%) ⬇️
...rc/simcore_service_director_v2/core/application.py 88.8% <80.0%> (-0.3%) ⬇️
...2/src/simcore_service_director_v2/core/settings.py 100.0% <100.0%> (+4.3%) ⬆️
.../src/simcore_service_director_v2/modules/celery.py 98.4% <100.0%> (+2.8%) ⬆️
...c/simcore_service_director_v2/modules/db/events.py 100.0% <100.0%> (ø)
... and 4 more

@sanderegg sanderegg requested review from pcrespov and GitHK July 7, 2021 14:14
@sanderegg sanderegg self-assigned this Jul 7, 2021
@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Jul 7, 2021
@sanderegg sanderegg added this to the Wombat milestone Jul 7, 2021
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thx for helping upgrading settings
some minor

services/director-v2/requirements/_base.in Outdated Show resolved Hide resolved
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I so not look forward to merge this 🤣

services/director-v2/tests/unit/test_core_settings.py Outdated Show resolved Hide resolved
@sanderegg sanderegg merged commit f5be61c into ITISFoundation:master Jul 7, 2021
@sanderegg sanderegg deleted the maintenance/use_settings_library branch July 7, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants