-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance/Director-v2 to use settings library #2427
♻️ Maintenance/Director-v2 to use settings library #2427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
========================================
- Coverage 75.5% 75.4% -0.1%
========================================
Files 560 558 -2
Lines 20868 20769 -99
Branches 2018 2008 -10
========================================
- Hits 15757 15674 -83
+ Misses 4577 4563 -14
+ Partials 534 532 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thx for helping upgrading settings
some minor
services/director-v2/src/simcore_service_director_v2/modules/dask.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I so not look forward to merge this 🤣
removed docker registry module as unused
What do these changes do?
Migrates the director-v2 to use the settings-library
Related issue/s
How to test
Checklist