Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ trying to boost CI speed #2510

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 27, 2021

What do these changes do?

[sys] public api runs up to 9 minutes faster now.

Benchmark Task Task Runtime Total Runtime
previous [sys] public api 21m 25m 0s
NOW [sys] public api 12m 24m 7s

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #2510 (c7734c2) into master (f04be82) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2510     +/-   ##
========================================
- Coverage    76.5%   76.5%   -0.1%     
========================================
  Files         600     600             
  Lines       22841   22841             
  Branches     2207    2207             
========================================
- Hits        17476   17474      -2     
+ Misses       4781    4780      -1     
- Partials      584     587      +3     
Flag Coverage Δ
integrationtests 67.0% <ø> (-0.1%) ⬇️
unittests 70.6% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/director_v2.py 76.1% <0.0%> (-1.2%) ⬇️
.../director/src/simcore_service_director/producer.py 61.4% <0.0%> (-0.9%) ⬇️
...simcore_service_webserver/projects/projects_api.py 84.8% <0.0%> (+1.4%) ⬆️

@GitHK GitHK self-assigned this Aug 27, 2021
@GitHK GitHK added t:enhancement Improvement or request on an existing feature t:maintenance Some planned maintenance work labels Aug 27, 2021
@GitHK GitHK added this to the Chevrotain milestone Aug 27, 2021
@GitHK GitHK marked this pull request as ready for review August 27, 2021 12:14
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so amazing!

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am beyond words

@GitHK GitHK merged commit 0322f0b into ITISFoundation:master Aug 27, 2021
@GitHK GitHK deleted the try-to-speedup-ci branch August 27, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants