Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ 🐛 pylint upgrade and fixes #2524

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 2, 2021

What do these changes do?

This should fix today's issues with the linter tests

pylint 2.10.2
astroid 2.7.3
Python 3.8.10 (default, Jun 15 2021, 10:37:55) 
[GCC 9.3.0]
  • 🐛 Fixes linter errors/warnings and recommendations (see commit messages)

@pcrespov pcrespov self-assigned this Sep 2, 2021
@pcrespov pcrespov added dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work labels Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2524 (f9f25c4) into master (7b53350) will decrease coverage by 0.0%.
The diff coverage is 57.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2524     +/-   ##
========================================
- Coverage    76.6%   76.6%   -0.1%     
========================================
  Files         601     601             
  Lines       22887   22878      -9     
  Branches     2217    2216      -1     
========================================
- Hits        17552   17533     -19     
- Misses       4749    4758      +9     
- Partials      586     587      +1     
Flag Coverage Δ
integrationtests 67.0% <47.0%> (-0.2%) ⬇️
unittests 70.7% <54.7%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 94.4% <ø> (ø)
...storage/src/simcore_service_storage/application.py 44.1% <ø> (ø)
...erver/src/simcore_service_webserver/computation.py 100.0% <ø> (ø)
.../web/server/src/simcore_service_webserver/email.py 82.3% <ø> (-1.0%) ⬇️
.../src/simcore_service_webserver/scicrunch/models.py 91.1% <0.0%> (ø)
...core_service_webserver/scicrunch/service_client.py 60.0% <0.0%> (ø)
...b/server/src/simcore_service_webserver/security.py 100.0% <ø> (ø)
.../simcore_service_webserver/security_permissions.py 43.7% <0.0%> (ø)
...eb/server/src/simcore_service_webserver/storage.py 100.0% <ø> (ø)
...er/src/simcore_service_webserver/login/handlers.py 87.8% <20.0%> (ø)
... and 17 more

@pcrespov pcrespov requested review from GitHK, sanderegg and mguidon and removed request for GitHK and sanderegg September 2, 2021 21:15
@pcrespov pcrespov changed the title ⬆️ pylint upgrade and fixes ⬆️ 🐛 pylint upgrade and fixes Sep 2, 2021
@pcrespov pcrespov added this to the Chevrotain milestone Sep 2, 2021
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question below.

.pylintrc Show resolved Hide resolved
@pcrespov pcrespov merged commit 321a180 into ITISFoundation:master Sep 3, 2021
@pcrespov pcrespov deleted the maintenance/pylint-upgrade-and-fix branch September 3, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants