Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Maintenance/enhance consistency checks #2533

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • also print out valid files CSV
  • added some doc

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Sep 9, 2021
@sanderegg sanderegg added this to the Chevrotain milestone Sep 9, 2021
@sanderegg sanderegg self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2533 (71269f8) into master (2b49ad5) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2533     +/-   ##
========================================
- Coverage    76.6%   76.6%   -0.1%     
========================================
  Files         610     610             
  Lines       23397   23397             
  Branches     2294    2294             
========================================
- Hits        17936   17929      -7     
- Misses       4857    4864      +7     
  Partials      604     604             
Flag Coverage Δ
integrationtests 66.3% <ø> (-0.1%) ⬇️
unittests 70.8% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._director_v2/modules/dynamic_sidecar/client_api.py 76.6% <0.0%> (-3.4%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 91.0% <0.0%> (-2.6%) ⬇️
...erver/src/simcore_service_webserver/director_v2.py 75.2% <0.0%> (-1.2%) ⬇️
...simcore_service_webserver/projects/projects_api.py 83.0% <0.0%> (-0.4%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 86.4% <0.0%> (+0.6%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 74.7% <0.0%> (+0.8%) ⬆️

@sanderegg sanderegg merged commit 90405a0 into ITISFoundation:master Sep 9, 2021
@sanderegg sanderegg deleted the maintenance/enhance-consistency-checks branch September 9, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants