Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/enhance consistency checks #2535

Conversation

sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

Checklist

@sanderegg sanderegg self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2535 (69c5cdb) into master (90405a0) will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2535     +/-   ##
========================================
- Coverage    74.9%   74.4%   -0.5%     
========================================
  Files         610     610             
  Lines       23397   23397             
  Branches     2294    2294             
========================================
- Hits        17539   17428    -111     
- Misses       5278    5400    +122     
+ Partials      580     569     -11     
Flag Coverage Δ
integrationtests 78.9% <ø> (+18.4%) ⬆️
unittests 70.8% <ø> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/computation_subscribe.py 30.0% <0.0%> (-61.3%) ⬇️
...rc/simcore_service_webserver/computation_config.py 68.4% <0.0%> (-26.4%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 61.2% <0.0%> (-24.5%) ⬇️
..._service_webserver/projects/projects_exceptions.py 76.1% <0.0%> (-23.9%) ⬇️
...erver/src/simcore_service_webserver/computation.py 76.9% <0.0%> (-23.1%) ⬇️
...simcore_service_webserver/projects/projects_api.py 68.9% <0.0%> (-14.5%) ⬇️
...ce_webserver/resource_manager/websocket_manager.py 93.1% <0.0%> (-4.2%) ⬇️
...erver/src/simcore_service_webserver/director_v2.py 70.6% <0.0%> (-3.5%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 61.3% <0.0%> (-1.3%) ⬇️
.../simcore_service_webserver/projects/projects_db.py 87.7% <0.0%> (-0.9%) ⬇️
... and 5 more

@sanderegg sanderegg merged commit 963fbd1 into ITISFoundation:master Sep 10, 2021
@sanderegg sanderegg deleted the maintenance/enhance-consistency-checks branch September 10, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants