Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance/week 38 dependencies #2545

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 20, 2021

What do these changes do?

  • 🐛 FIX: After PR ♻️ Maintenance/refactors servicelib #2516, servicelib dependencies were reduced by adding a separate [aiohttp] extra requirements option. Since servicelib is also (wrongly) added as a dependency by simcore-sdk, then several services requirements were not updated, namely public-api, sidecar, dask-sidecar and tests/swarm

  • ⬆️ Full repo upgrades

  • Updates docs, Makefile

In order to avoid too much clutter, we will upgrade second-order test/tooling libraries in a separate PR

Related issue/s

How to test

All tests involved

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #2545 (7a777ba) into master (f91f7ea) will decrease coverage by 5.4%.
The diff coverage is 88.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2545     +/-   ##
========================================
- Coverage    76.9%   71.4%   -5.5%     
========================================
  Files         619     619             
  Lines       23958   23968     +10     
  Branches     2345    2345             
========================================
- Hits        18429   17133   -1296     
- Misses       4905    6289   +1384     
+ Partials      624     546     -78     
Flag Coverage Δ
integrationtests ?
unittests 71.4% <88.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dapter/src/simcore_service_datcore_adapter/meta.py 76.4% <0.0%> (-4.8%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 75.2% <0.0%> (ø)
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 42.1% <100.0%> (-43.6%) ⬇️
...mcore_service_datcore_adapter/modules/pennsieve.py 90.9% <100.0%> (+<0.1%) ⬆️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 85.2% <100.0%> (-2.8%) ⬇️
...erver/src/simcore_service_webserver/clusters/db.py 87.9% <100.0%> (+0.1%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 88.4% <100.0%> (-1.9%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 89.6% <100.0%> (+<0.1%) ⬆️
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 29.6% <0.0%> (-70.4%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 35.8% <0.0%> (-64.2%) ⬇️
... and 76 more

@pcrespov pcrespov self-assigned this Sep 20, 2021
@pcrespov pcrespov added this to the Capra delle nevi milestone Sep 20, 2021
@pcrespov pcrespov marked this pull request as ready for review September 20, 2021 13:01
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@pcrespov pcrespov merged commit e7cb9c7 into ITISFoundation:master Sep 20, 2021
@pcrespov pcrespov deleted the maintenance/week38-dependencies branch September 20, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants