Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Activate tracing in aiohttp-based services #2559

Merged
merged 34 commits into from
Oct 21, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 27, 2021

What do these changes do?

Reviews and upgrades tracing helpers in aiohttp-based services, namely webserver, storage and director

  • ♻️ improves servicelib.tracing.setup_tracing
    • Implemented sync to enforce order of middlewares
    • web-server has still old settings. Needs TRACING_ENABLED=1 (will be refactored as soon as we have new settings in place)
    • storage has new settings and can be configured using Settings.STORAGE_TRACING
  • ♻️ servicelib.aiohttp.rest_middlewares doc and annotated
  • ⬆️ upgrades client to the latest releaseaiozipkin==1.1.0 : could not be done due to a bug in library. Issue replicated in test packages/service-library/tests/aiohttp/test_tracing.py

@pcrespov pcrespov changed the title Fix/activate tracing aiohttp 🐛 Activate tracing in aiohttp-based services Sep 27, 2021
@pcrespov pcrespov self-assigned this Sep 27, 2021
@pcrespov pcrespov added this to the Capra delle nevi milestone Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #2559 (f035a25) into master (71579eb) will increase coverage by 1.1%.
The diff coverage is 83.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2559     +/-   ##
========================================
+ Coverage    77.2%   78.3%   +1.1%     
========================================
  Files         618     582     -36     
  Lines       23910   22934    -976     
  Branches     2356    2246    -110     
========================================
- Hits        18472   17972    -500     
+ Misses       4810    4333    -477     
- Partials      628     629      +1     
Flag Coverage Δ
integrationtests 65.8% <68.9%> (-0.1%) ⬇️
unittests 72.6% <83.9%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...storage/src/simcore_service_storage/application.py 44.1% <0.0%> (ø)
...ervices/storage/src/simcore_service_storage/cli.py 47.8% <28.5%> (-11.0%) ⬇️
.../simcore_service_webserver/diagnostics_handlers.py 55.2% <40.0%> (+0.6%) ⬆️
...library/src/servicelib/aiohttp/rest_middlewares.py 64.4% <78.2%> (+2.2%) ⬆️
...ibrary/src/servicelib/aiohttp/application_setup.py 81.9% <100.0%> (ø)
...e-library/src/servicelib/aiohttp/rest_responses.py 84.2% <100.0%> (+0.2%) ⬆️
.../service-library/src/servicelib/aiohttp/tracing.py 100.0% <100.0%> (+100.0%) ⬆️
...library/src/servicelib/aiohttp/typing_extension.py 100.0% <100.0%> (ø)
...ices/director/src/simcore_service_director/main.py 88.2% <100.0%> (-3.8%) ⬇️
...es/storage/src/simcore_service_storage/settings.py 100.0% <100.0%> (ø)
... and 56 more

@pcrespov pcrespov removed this from the Capra delle nevi milestone Oct 20, 2021
@pcrespov pcrespov marked this pull request as ready for review October 20, 2021 19:08
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Please find a few questions below.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit 41132a9 into ITISFoundation:master Oct 21, 2021
@pcrespov pcrespov deleted the fix/activate-tracing-aiohttp branch October 21, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants