-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactors webserver module director_v2
and breaks dependency cycles
#2567
♻️ Refactors webserver module director_v2
and breaks dependency cycles
#2567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
========================================
+ Coverage 76.8% 77.0% +0.1%
========================================
Files 623 618 -5
Lines 24050 24073 +23
Branches 2357 2347 -10
========================================
+ Hits 18483 18537 +54
+ Misses 4938 4907 -31
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more.
|
director_v2
and breaks dependency cycles
services/web/server/src/simcore_service_webserver/version_control_db.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok... I'm a little bit scared of my next rebase ;)
f66c4fd
to
4f0b932
Compare
What do these changes do?
This PR refactors
web-server
service to prepare for new features that will be introduce in a separate PR #2556director-v2
app module into submodules forBaseSettings
-based settings with options to configure this moduleaiohttp
'sapp.router
project
app module's handler into smaller submodulesTimeoutError
byasyncio.TimeoutError
. Those are differemt things.simcore_service_webserver.utils
Related issue/s
How to test
Checklist