Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure director has started before getting services #2609

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 28, 2021

What do these changes do?

  • ensures that the director-v0 is ready for receiving requests before the catalog says he is ready to get the services
    Should fix the instabilities in the CI for at least e2e testing

Related issue/s

How to test

Checklist

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sanderegg sanderegg added the a:catalog catalog service label Oct 28, 2021
@sanderegg sanderegg added this to the Anti-PER milestone Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2609 (96b3fc0) into master (6e67a44) will decrease coverage by 8.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2609      +/-   ##
=========================================
- Coverage    77.0%   68.3%    -8.7%     
=========================================
  Files         631     362     -269     
  Lines       24752   12372   -12380     
  Branches     2430    1257    -1173     
=========================================
- Hits        19069    8456   -10613     
+ Misses       5042    3627    -1415     
+ Partials      641     289     -352     
Flag Coverage Δ
integrationtests ?
unittests 68.3% <ø> (-3.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 29.6% <0.0%> (-70.4%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 32.6% <0.0%> (-67.4%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...ore_service_director_v2/api/routes/computations.py 33.0% <0.0%> (-54.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 41.5% <0.0%> (-53.6%) ⬇️
...es/sidecar/src/simcore_service_sidecar/executor.py 27.4% <0.0%> (-51.0%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 29.1% <0.0%> (-50.0%) ⬇️
...dynamic_sidecar/docker_service_specs/spec_proxy.py 53.8% <0.0%> (-46.2%) ⬇️
..._director_v2/modules/db/repositories/comp_tasks.py 50.0% <0.0%> (-45.8%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 36.7% <0.0%> (-43.8%) ⬇️
... and 309 more

@sanderegg sanderegg merged commit 3aff410 into ITISFoundation:master Oct 28, 2021
@sanderegg sanderegg deleted the maintenance/check_for_director_being_up branch October 28, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants