Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review Project entrypoint in webserver #2980

Open
sanderegg opened this issue Apr 11, 2022 · 1 comment
Open

review Project entrypoint in webserver #2980

sanderegg opened this issue Apr 11, 2022 · 1 comment
Assignees
Labels
a:frontend issue affecting the front-end (area group) a:webserver issue related to the webserver service t:enhancement Improvement or request on an existing feature

Comments

@sanderegg
Copy link
Member

Currently the frontend uses the following endpoints:

  • POST /projects -> creates a new project (updates DB)
  • PUT /projects/{puuid} --> replaces the current project (updates DB) - is called a lot from frontend
  • POST /projects/{puuid}/nodes --> create a new node BUT does not update the DB
  • DELETE /projects/{puuid}/nodes --> deletes node (stops dynamic service) BUT does not update DB

All this needs a review and should at least be modified like so (all should modify the DB):

  • POST /projects -> creates a new project, returns among other the project UUID
  • PUT /projects/{puuid} --> replaces the current project , its use should be reduced
  • PATCH /projects/{puuid} --> updates the project (for sharing rights, TSR, etc, project related stuff mostly)
  • POST /projects/{puuid}/nodes --> create a new node (pass key,version, params if frontend node)
    (- GET /projects/{puuid}/nodes --> get all the nodes in the project)
  • GET /projects/{puuid}/nodes/{nuuid} --> get a node
    (- PUT /projects/{puuid}/nodes/{nuuid} --> replaces node)
  • PATCH /projects/{puuid}/nodes/{nuuid} --> modify a node (for example position, parameters, etc...)
  • DELETE /projects/{puuid}/nodes/{nuuid} --> deletes node (stops dynamic service, stops computation if running and forced)
@sanderegg sanderegg added a:frontend issue affecting the front-end (area group) a:webserver issue related to the webserver service labels Apr 11, 2022
@odeimaiz odeimaiz added the bug buggy, it does not work as expected label Apr 11, 2022
@sanderegg
Copy link
Member Author

sanderegg commented Sep 9, 2022

@sanderegg sanderegg removed the bug buggy, it does not work as expected label Feb 28, 2023
@pcrespov pcrespov assigned pcrespov and unassigned sanderegg Apr 12, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 12, 2023
@pcrespov pcrespov added the t:enhancement Improvement or request on an existing feature label Apr 12, 2023
@pcrespov pcrespov modified the milestones: Jelly Beans, Watermelon Jun 8, 2023
@pcrespov pcrespov modified the milestones: Watermelon, Sundae Jul 25, 2023
@pcrespov pcrespov modified the milestones: Sundae, Baklava Aug 21, 2023
@pcrespov pcrespov modified the milestones: Baklava, the nameless Sep 13, 2023
@sanderegg sanderegg removed this from the the nameless milestone Apr 12, 2024
@pcrespov pcrespov modified the milestone: Enchanted Odyssey Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) a:webserver issue related to the webserver service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants