Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: old services are using outdated Docker REST API, or wrong #3044

Closed
sanderegg opened this issue May 13, 2022 · 1 comment
Closed
Assignees
Labels
bug buggy, it does not work as expected
Milestone

Comments

@sanderegg
Copy link
Member

Most of 3rd party services that define a resource reservation do it by setting a label such as:

{"Resources" {"Reservations":{"NanoCPUs":123}}}

This is wrong and should be:

{"Resources" {"Reservation":{"NanoCPUs":123}}}

see https://docs.docker.com/engine/api/v1.41/#operation/ServiceCreate

Nevertheless we should also keep backward compatibility.

For info @pcrespov , @GitHK , @mguidon , @odeimaiz

@sanderegg sanderegg added the bug buggy, it does not work as expected label May 13, 2022
@sanderegg sanderegg added this to the Croissant milestone May 13, 2022
@sanderegg sanderegg self-assigned this May 13, 2022
@sanderegg
Copy link
Member Author

actually this was a wrong assessment, and the Docker REST API has been corrected.
It's "Reservations"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

No branches or pull requests

1 participant