Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail services boot if product validaton fails #3453

Closed
pcrespov opened this issue Oct 17, 2022 · 0 comments · Fixed by #3455
Closed

Fail services boot if product validaton fails #3453

pcrespov opened this issue Oct 17, 2022 · 0 comments · Fixed by #3455
Assignees
@pcrespov

Comments

@pcrespov
Copy link
Member

pcrespov commented Oct 17, 2022 •
edited

@Surfict wrote

Release to staging just completed. We had to update the products table in both staging aws and staging dalco as an entry in the manual_url was not with https but with http, which prevented the webserver to start correctly (symptoms : impossible to log in)

Release notes: https://github.com/ITISFoundation/osparc-simcore/releases/tag/staging_switzer1

_Originally posted by @Surfict in ITISFoundation/osparc-issues#750

When product validation fails we should stop the service from starting. Otherwise the error gets buried in the logs ...
@pcrespov pcrespov self-assigned this Oct 17, 2022
@pcrespov pcrespov changed the title Fail startup if product fails Fail services boot if product validaton fails Oct 17, 2022
@pcrespov pcrespov mentioned this issue Oct 17, 2022
Merged
@sanderegg sanderegg mentioned this issue Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ is3453/fail boot if invalid product setup pcrespov/osparc-simcore
1 participant
@pcrespov