Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and build directory outside of the source tree? #346

Open
gshamov opened this issue Apr 16, 2020 · 1 comment
Open

Install and build directory outside of the source tree? #346

gshamov opened this issue Apr 16, 2020 · 1 comment

Comments

@gshamov
Copy link

gshamov commented Apr 16, 2020

Hi All,

It would be good to make Itensor to work with standard best practices, that is, to work outside of the source three. PREFIX should be the target installation directory (where you'd put headers and libraries). Not the source directory.

Right now setting PREFIX in options.mk seems to break the build, which is rather gross.

Thanks!

@emstoudenmire
Copy link
Contributor

emstoudenmire commented May 10, 2020

Hi, thanks for the feedback about this. I agree there are some improvements we should make to the build system, and definitely we should change the name of the PREFIX variable to something else so it doesn't conflict with the usual meaning, so we will at least do that.

I do also agree it's a good idea to allow installing libraries and headers outside the source tree (though personally I still like how we default to inside, and I think it's worked well for our users, many of whom are unix novices). So I'll look into that and it should be easy to define a make install target that installs into a PREFIX of the users choosing.

Thanks,
Miles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants