Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch packages over to using ITensorMPS.jl #3

Closed
15 of 18 tasks
mtfishman opened this issue May 9, 2024 · 4 comments
Closed
15 of 18 tasks

Switch packages over to using ITensorMPS.jl #3

mtfishman opened this issue May 9, 2024 · 4 comments

Comments

@mtfishman
Copy link
Member

mtfishman commented May 9, 2024

@emstoudenmire
Copy link
Contributor

Best I can tell, no code in ITensorMakie.jl depends on ITensorMPS. So we can mark that one completed.

@mtfishman
Copy link
Member Author

mtfishman commented May 15, 2024

This is nearly complete, ITensorAFQMC.jl is private and not very functional anyway so isn't urgent to update, ITensorMPOCompression.jl has a pending PR, and PastaQ.jl has a pending PR which is hitting some issues that is very likely not directly caused by ITensorMPS.jl.

@emstoudenmire what's the status of ITensorQTT.jl? Can we take a minimal path to upgrading it to using ITensorMPS.jl now that #7 is complete? I think we shouldn't do anything ambitious there, at least not right now for the sake of completing this issue.

@emstoudenmire
Copy link
Contributor

Good reminder. Now that ITensorMPS is updated, ITensorQTT can access all the types and methods it needs again, so tests are passing and I just made an ITensorQTT PR here: ITensor/ITensorQTT.jl#11

The biggest change is that I deleted ITensorQTT.linsolve since it's essentially the same as ITensorTDVP's linsolve (since it has the same signature it was causing a warning, otherwise I might have just left it alone).

@mtfishman
Copy link
Member Author

Ok this is implemented as much as possible right now so I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants