Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityDescriptor and EntitiesDescriptor #186

Open
Ghostbird opened this issue Mar 27, 2024 · 3 comments
Open

EntityDescriptor and EntitiesDescriptor #186

Ghostbird opened this issue Mar 27, 2024 · 3 comments

Comments

@Ghostbird
Copy link

How do I get EntiesDescriptor in the metadata?

// Summary:
// The EntitiesDescriptor element contains the metadata for an optionally named
// group of SAML entities.
public class EntityDescriptor

The documentation is plural, but the element is singular. It seems that EntitiesDescriptor XML element is not supported, and the documentation is wrong.

@Ghostbird
Copy link
Author

Ghostbird commented Mar 28, 2024

I looked into this a bit more, and there's some weird stuff that seems to belong on Saml2Metadata that's implemented on EntityDescriptor. It seems centred around the ctor that takes a Saml2Configuration and signMetadata option.

The function EntityDescriptor.ToXmlDocument(); is exclusively called from Saml2Medata.

@Ghostbird
Copy link
Author

Ghostbird commented Mar 28, 2024

I've got a local branch almost working. I hope to make a PR next week.

@Ghostbird
Copy link
Author

See #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant