Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Security for State Changing Operations and File Deletion #129

Open
deepakduggirala opened this issue Dec 22, 2023 · 0 comments
Open
Labels

Comments

@deepakduggirala
Copy link
Contributor

We need to improve the security of our application by implementing stricter controls on state changing operations and file deletion. The following enhancements are proposed:

  1. State Changing Operations: We need to strictly lock down all state changing operations (POST, PUT, PATCH, DELETE). We should clearly define what attributes users can update or create or delete.

  2. Worker Role: Operators and admins should not be able to change paths and other attributes on the dataset. Only a worker should have this capability. We need to create a worker role to enforce this restriction.

  3. Human in the Loop for File Deletion: To prevent accidental or malicious deletion of files on SDA, we should implement a "human in the loop" mechanism. This means that a human must manually approve any SDA file deletion operations.

Acceptance Criteria:

  • State changing operations are locked down and only allow users to update or create specific attributes.
  • A worker role is created and only workers can change paths and other attributes on the dataset.
  • A "human in the loop" mechanism is implemented for file deletion on SDA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants