Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on moving away from eslint-summary? #107

Open
TheBox193 opened this issue Apr 10, 2023 · 1 comment · May be fixed by #108
Open

Thoughts on moving away from eslint-summary? #107

TheBox193 opened this issue Apr 10, 2023 · 1 comment · May be fixed by #108

Comments

@TheBox193
Copy link

Background

eslint-summary provides the summary line for eslint-nibble.
image

While eslint-nibble has been maintained, eslint-summary has not for ~8yrs. For example eslint-nibble is using "chalk": "^4.1.1" while eslint-summary is still on "chalk": "^1.0.0".

The functionality of eslint-summary is rather straightforward. Does it make sense to adopt and pull this code into eslint-nibble?

This came to my attention when looking through my repos dependencies and vulnerabilities and chasing down where older versions of chalk where coming from.

Thoughts?

I would be happy to open a PR & add some unit tests if there is interest. 🙂

@IanVS
Copy link
Owner

IanVS commented Apr 10, 2023

That sounds like a good idea. Normally I'd suggest submitting a PR upstream, but the author has not been on GitHub for years it looks like, so I think that would be fruitless. I'd be happy to accept a PR that pulls it into eslint-nibble itself. Thanks for the offer.

@TheBox193 TheBox193 linked a pull request May 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants