Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom :page param #24

Open
kurenn opened this issue Jun 8, 2018 · 0 comments
Open

Add custom :page param #24

kurenn opened this issue Jun 8, 2018 · 0 comments

Comments

@kurenn
Copy link
Member

kurenn commented Jun 8, 2018

On a conversation with @ddnexus and @cseelus we were discussing about the possibility of having a a configuration option for the :page param, rather than hard coding it to :page.

This should work for the 3 supported pagination gems(Pagy, Kaminari, WillPaginate)

Here are some notes:

From a (resolved) Pagy issue:

The ability to add arbitrary params similar to will_paginates :params option or Kaminaris option with the same name would be helpful for a number of use cases:

[…] (not applicable for API pagination)
Passing search/form params around, when Pagy is used in combination with a search function
Passing in a controller/action name (see will_paginate or Kaminaris docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant